bench: add generic zk_from_json() which will benchmark most .zk files using witness.json files provided.

Cargo.toml

@@ -319,4 +319,8 @@ pathfinder_simd = {git="https://github.com/servo/pathfinder", branch="main"}
 name = "zk_arith"
 harness = false
 path = "bench/zk_arith.rs"
+[[bench]]
+name = "zk_from_json"
+harness = false
+path = "bench/zk_from_json.rs"
 

bench/zk_arith.rs

@@ -30,7 +30,7 @@ use darkfi::{
     zkas::ZkBinary,
 };
 
-fn zk_arith_bench(c: &mut Criterion) {
+fn zk_arith(c: &mut Criterion) {
     let bincode = include_bytes!("../proof/arithmetic.zk.bin");
     let zkbin = ZkBinary::decode(bincode).unwrap();
 
@@ -40,10 +40,12 @@ fn zk_arith_bench(c: &mut Criterion) {
     let prover_witnesses = vec![Witness::Base(Value::known(a)), Witness::Base(Value::known(b))];
     let public_inputs = vec![a + b, a * b, a - b];
 
+    //darkfi::zk::export_witness_json("proof/witness/arithmetic.json", &prover_witnesses, &public_inputs);
     let circuit = ZkCircuit::new(prover_witnesses.clone(), &zkbin);
 
     let mut prove_group = c.benchmark_group("prove");
-    for k in 11..20 {
+    prove_group.significance_level(0.01).sample_size(10);
+    for k in zkbin.k..20 {
         let proving_key = ProvingKey::build(k, &circuit.clone());
         prove_group.bench_with_input(BenchmarkId::from_parameter(k), &k, |b, &_k| {
             b.iter(|| Proof::create(&proving_key, &[circuit.clone()], &public_inputs, &mut OsRng))
@@ -52,7 +54,8 @@ fn zk_arith_bench(c: &mut Criterion) {
     prove_group.finish();
 
     let mut verif_group = c.benchmark_group("verify");
-    for k in 11..20 {
+    verif_group.significance_level(0.01).sample_size(10);
+    for k in zkbin.k..20 {
         let proving_key = ProvingKey::build(k, &circuit.clone());
         let proof =
             Proof::create(&proving_key, &[circuit.clone()], &public_inputs, &mut OsRng).unwrap();
@@ -67,5 +70,5 @@ fn zk_arith_bench(c: &mut Criterion) {
     verif_group.finish();
 }
 
-criterion_group!(benches, zk_arith_bench);
-criterion_main!(benches);
+criterion_group!(bench, zk_arith);
+criterion_main!(bench);

bench/zk_from_json.rs

@@ -0,0 +1,168 @@
+/* This file is part of DarkFi (https://dark.fi)
+ *
+ * Copyright (C) 2020-2024 Dyne.org foundation
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
+use rand::rngs::OsRng;
+use std::{fs::File, io::Read};
+
+use darkfi::{
+    zk::{
+        proof::{ProvingKey, VerifyingKey},
+        vm::ZkCircuit,
+        vm_heap::empty_witnesses,
+        Proof,
+    },
+    zkas::ZkBinary,
+};
+
+// Use a witness.json file to benchmark a ZK file
+fn zk_from_json(c: &mut Criterion) {
+    #[rustfmt::skip]
+    let tests = [
+        (
+            "Opcodes",
+            "../proof/opcodes.zk",
+            "../proof/witness/opcodes.json"
+        ),
+        (
+            "Arithmetic",
+            "../proof/arithmetic.zk",
+            "../proof/witness/arithmetic.json"
+        ),
+        (
+            "SMT",
+            "../proof/smt.zk",
+            "../proof/witness/smt.json"
+        ),
+        (
+            "DAO::mint",
+            "../src/contract/dao/proof/mint.zk",
+            "../src/contract/dao/proof/witness/mint.json"
+        ),
+        (
+            "DAO::propose-input",
+            "../src/contract/dao/proof/propose-input.zk",
+            "../src/contract/dao/proof/witness/propose-input.json"
+        ),
+        (
+            "DAO::propose",
+            "../src/contract/dao/proof/propose-main.zk",
+            "../src/contract/dao/proof/witness/propose-main.json"
+        ),
+        (
+            "DAO::vote-input",
+            "../src/contract/dao/proof/vote-input.zk",
+            "../src/contract/dao/proof/witness/vote-input.json"
+        ),
+        (
+            "DAO::vote",
+            "../src/contract/dao/proof/vote-main.zk",
+            "../src/contract/dao/proof/witness/vote-main.json"
+        ),
+        (
+            "DAO::exec",
+            "../src/contract/dao/proof/exec.zk",
+            "../src/contract/dao/proof/witness/exec.json"
+        ),
+        (
+            "DAO::auth_xfer-coin",
+            "../src/contract/dao/proof/auth-money-transfer-enc-coin.zk",
+            "../src/contract/dao/proof/witness/auth-money-transfer-enc-coin.json"
+        ),
+        (
+            "DAO::auth_xfer",
+            "../src/contract/dao/proof/auth-money-transfer.zk",
+            "../src/contract/dao/proof/witness/auth-money-transfer.json"
+        ),
+        (
+            "Money::xfer-mint",
+            "../src/contract/money/proof/mint_v1.zk",
+            "../src/contract/money/proof/witness/mint_v1.json"
+        ),
+        (
+            "Money::xfer-burn",
+            "../src/contract/money/proof/burn_v1.zk",
+            "../src/contract/money/proof/witness/burn_v1.json"
+        ),
+        (
+            "Money::fee",
+            "../src/contract/money/proof/fee_v1.zk",
+            "../src/contract/money/proof/witness/fee_v1.json"
+        ),
+        (
+            "Money::auth_token-mint",
+            "../src/contract/money/proof/auth_token_mint_v1.zk",
+            "../src/contract/money/proof/witness/auth_token_mint_v1.json"
+        ),
+        (
+            "Money::token-mint",
+            "../src/contract/money/proof/token_mint_v1.zk",
+            "../src/contract/money/proof/witness/token_mint_v1.json"
+        ),
+        (
+            "Money::token-freeze",
+            "../src/contract/money/proof/token_freeze_v1.zk",
+            "../src/contract/money/proof/witness/token_freeze_v1.json"
+        ),
+    ];
+
+    for (name, proof, witness) in &tests {
+        run_benchmark(c, name, proof, witness);
+    }
+}
+
+fn run_benchmark(c: &mut Criterion, name: &str, proof: &str, witness: &str) {
+    let mut bincode = Vec::new();
+    let mut f = File::open(proof).unwrap();
+    f.read_to_end(&mut bincode).unwrap();
+    let zkbin = ZkBinary::decode(&bincode).unwrap();
+
+    let (prover_witnesses, public_inputs) = darkfi::zk::import_witness_json(witness);
+    let circuit = ZkCircuit::new(prover_witnesses.clone(), &zkbin);
+
+    let mut prove_group = c.benchmark_group(format!("prove {}", name));
+    prove_group.significance_level(0.01).sample_size(10);
+
+    for k in zkbin.k..20 {
+        let proving_key = ProvingKey::build(k, &circuit.clone());
+        prove_group.bench_with_input(BenchmarkId::from_parameter(k), &k, |b, &_k| {
+            b.iter(|| Proof::create(&proving_key, &[circuit.clone()], &public_inputs, &mut OsRng))
+        });
+    }
+    prove_group.finish();
+
+    let mut verif_group = c.benchmark_group(format!("verify {}", name));
+    verif_group.significance_level(0.01).sample_size(10);
+
+    for k in zkbin.k..20 {
+        let proving_key = ProvingKey::build(k, &circuit.clone());
+        let proof =
+            Proof::create(&proving_key, &[circuit.clone()], &public_inputs, &mut OsRng).unwrap();
+        let verifier_witnesses = empty_witnesses(&zkbin).unwrap();
+        let circuit = ZkCircuit::new(verifier_witnesses, &zkbin);
+        let verifying_key = VerifyingKey::build(k, &circuit);
+
+        verif_group.bench_with_input(BenchmarkId::from_parameter(k), &k, |b, &_k| {
+            b.iter(|| proof.verify(&verifying_key, &public_inputs))
+        });
+    }
+    verif_group.finish();
+}
+
+criterion_group!(bench, zk_from_json);
+criterion_main!(bench);