浏览代码

dao: note on critical vuln that needs fixing

x 2 年之前
父节点
当前提交
34b14f9e72
共有 1 个文件被更改,包括 4 次插入0 次删除
  1. 4 0
      src/contract/dao/src/entrypoint/exec.rs

+ 4 - 0
src/contract/dao/src/entrypoint/exec.rs

@@ -52,6 +52,10 @@ pub(crate) fn dao_exec_get_metadata(
     let all_vote_coords = blind_vote.all_vote_commit.to_affine().coordinates().unwrap();
     let all_vote_coords = blind_vote.all_vote_commit.to_affine().coordinates().unwrap();
     let input_value_coords = params.input_value_commit.to_affine().coordinates().unwrap();
     let input_value_coords = params.input_value_commit.to_affine().coordinates().unwrap();
 
 
+    // TODO (CRITICAL): deserialize MoneyTransfer data, and pass user_data_enc below.
+    //                  This should be enforced inside the ZK contract.
+    //                  When decrypted it should match dao_bulla.
+
     zk_public_inputs.push((
     zk_public_inputs.push((
         DAO_CONTRACT_ZKAS_DAO_EXEC_NS.to_string(),
         DAO_CONTRACT_ZKAS_DAO_EXEC_NS.to_string(),
         vec![
         vec![