wallet/chatedit: fine tune vertical scrolling and select handles

bin/darkwallet/src/app/mod.rs

@@ -162,7 +162,7 @@ impl App {
 
         let window = window.setup(|me| Window::new(me, self.render_api.clone())).await;
         self.sg_root.clone().link(window.clone());
-        schema::make_test(&self, window).await;
+        schema::make(&self, window).await;
 
         debug!(target: "app", "Schema loaded");
     }

bin/darkwallet/src/app/schema.rs

@@ -47,13 +47,14 @@ const LIGHTMODE: bool = false;
 
 mod android_ui_consts {
     pub const EDITCHAT_HEIGHT: f32 = 163.;
-    pub const EDITCHAT_BOTTOM_PAD: f32 = 50.;
+    pub const EDITCHAT_BOTTOM_PAD: f32 = 30.;
     pub const EDITCHAT_CURSOR_ASCENT: f32 = 50.;
     pub const EDITCHAT_CURSOR_DESCENT: f32 = 20.;
     pub const EDITCHAT_SELECT_ASCENT: f32 = 40.;
     pub const EDITCHAT_SELECT_DESCENT: f32 = 8.;
-    pub const EDITCHAT_HANDLE_DESCENT: f32 = 33.;
-    pub const TEXTBAR_BASELINE: f32 = 93.;
+    pub const EDITCHAT_HANDLE_DESCENT: f32 = 10.;
+    pub const EDITCHAT_LINESPACING: f32 = 70.;
+    pub const TEXTBAR_BASELINE: f32 = 60.;
     pub const TEXT_DESCENT: f32 = 20.;
     pub const EDITCHAT_LHS_PAD: f32 = 30.;
     pub const SENDLABEL_WIDTH: f32 = 200.;
@@ -916,7 +917,7 @@ pub(super) async fn make(app: &App, window: SceneNodePtr) {
     editbox_bg_rect_prop.add_depend(&prop, 3, "editz_h");
 
     node.set_property_f32(Role::App, "baseline", TEXTBAR_BASELINE).unwrap();
-    node.set_property_f32(Role::App, "linespacing", TEXTBAR_BASELINE).unwrap();
+    node.set_property_f32(Role::App, "linespacing", EDITCHAT_LINESPACING).unwrap();
     node.set_property_f32(Role::App, "descent", TEXT_DESCENT).unwrap();
     node.set_property_f32(Role::App, "font_size", FONTSIZE).unwrap();
     //node.set_property_str(Role::App, "text", "hello king!😁🍆jelly 🍆1234").unwrap();
@@ -963,7 +964,7 @@ pub(super) async fn make(app: &App, window: SceneNodePtr) {
     prop.set_null(Role::App, 0).unwrap();
     prop.set_null(Role::App, 1).unwrap();
     node.set_property_u32(Role::App, "z_index", 3).unwrap();
-    //node.set_property_bool(Role::App, "debug", true).unwrap();
+    node.set_property_bool(Role::App, "debug", true).unwrap();
 
     //let editbox_text = PropertyStr::wrap(node, Role::App, "text", 0).unwrap();
     //let editbox_focus = PropertyBool::wrap(node, Role::App, "is_focused", 0).unwrap();

bin/darkwallet/src/ui/chatedit.rs

@@ -38,7 +38,7 @@ use crate::{
         GfxDrawCall, GfxDrawInstruction, GfxDrawMesh, GfxTextureId, GraphicsEventPublisherPtr,
         Point, Rectangle, RenderApi, Vertex,
     },
-    mesh::{MeshBuilder, MeshInfo, COLOR_BLUE, COLOR_WHITE},
+    mesh::{MeshBuilder, MeshInfo, COLOR_BLUE, COLOR_RED, COLOR_WHITE},
     prop::{
         PropertyBool, PropertyColor, PropertyFloat32, PropertyPtr, PropertyRect, PropertyStr,
         PropertyUint32, Role,
@@ -378,7 +378,7 @@ impl TouchInfo {
                         debug!(target: "ui::chatedit::touch", "update touch state: Started -> StartSelect");
                         self.state = TouchStateAction::StartSelect;
                     }
-                } else if grad > 0.5 {
+                } else if grad.abs() > 0.5 {
                     // Vertical movement
                     debug!(target: "ui::chatedit::touch", "update touch state: Started -> ScrollVert");
                     let scroll_start = self.scroll.get();
@@ -440,7 +440,6 @@ pub struct ChatEdit {
     z_index: PropertyUint32,
     debug: PropertyBool,
 
-    select: SyncMutex<Vec<Selection>>,
     text_wrap: SyncMutex<TextWrap>,
 
     mouse_btn_held: AtomicBool,
@@ -554,7 +553,6 @@ impl ChatEdit {
             z_index,
             debug,
 
-            select: SyncMutex::new(vec![]),
             text_wrap: SyncMutex::new(TextWrap::new(
                 text_shaper,
                 font_size,
@@ -691,6 +689,9 @@ impl ChatEdit {
                     color = COLOR_WHITE;
                 }
                 mesh.draw_box(&glyph_rect, color, uv_rect);
+                if self.debug.get() {
+                    mesh.draw_outline(&glyph_rect, COLOR_RED, 1.);
+                }
             }
 
             curr_y += linespacing;
@@ -704,6 +705,10 @@ impl ChatEdit {
             self.draw_phone_select_handle(&mut mesh, select.end, &wrapped_lines, 1.);
         }
 
+        if self.debug.get() {
+            mesh.draw_outline(&clip, COLOR_BLUE, 1.);
+        }
+
         mesh.alloc(&self.render_api).draw_with_texture(atlas.texture)
     }
 
@@ -1044,7 +1049,7 @@ impl ChatEdit {
     fn delete(&self, before: usize, after: usize) {
         let mut text_wrap = &mut self.text_wrap.lock();
         text_wrap.clear_cache();
-        let selection = std::mem::take(&mut *self.select.lock());
+        let selection = std::mem::take(&mut self.text_wrap.lock().select);
 
         if selection.is_empty() {
             text_wrap.editable.delete(before, after);
@@ -1089,7 +1094,7 @@ impl ChatEdit {
         drop(text_wrap);
         debug!(target: "ui::editbox", "Adjust cursor pos to {cursor_pos}");
 
-        let mut select = self.select.lock();
+        let select = &mut self.text_wrap.lock().select;
 
         // Start selection if shift is held
         if has_shift {
@@ -1311,7 +1316,6 @@ impl ChatEdit {
                     let select = selections.first_mut().unwrap();
 
                     let mut point = touch_pos;
-                    point.y -= linespacing + handle_descent;
 
                     // Only allow selecting text that is visible in the box
                     // We do our calcs relative to (0, 0) so bhs = rect_h
@@ -1319,6 +1323,8 @@ impl ChatEdit {
                     debug!(target: "ui::chatedit", "min({}, {rect_bhs})", point.y);
                     point.y = min_f32(point.y, rect_bhs);
 
+                    point.y -= linespacing + handle_descent;
+
                     let mut pos = wrapped_lines.point_to_pos(point);
                     debug!(target: "ui::chatedit", "desired pos = {point:?} [touch_pos={touch_pos:?}");
 
@@ -1588,6 +1594,10 @@ impl UIObject for ChatEdit {
         }
         on_modify.when_change(self.rect.prop(), redraw);
         on_modify.when_change(self.baseline.prop(), redraw);
+        on_modify.when_change(self.linespacing.prop(), redraw);
+        on_modify.when_change(self.select_ascent.prop(), redraw);
+        on_modify.when_change(self.select_descent.prop(), redraw);
+        on_modify.when_change(self.handle_descent.prop(), redraw);
         // The commented properties are modified on input events
         // So then redraw() will get repeatedly triggered when these properties
         // are changed. We should find a solution. For now the hooks are disabled.
@@ -1715,7 +1725,7 @@ impl UIObject for ChatEdit {
             if self.is_focused.get() {
                 debug!(target: "ui::chatedit", "EditBox unfocused");
                 self.is_focused.set(false);
-                self.select.lock().clear();
+                self.text_wrap.lock().select.clear();
 
                 self.redraw().await;
             }

bin/darkwallet/src/util.rs

@@ -23,7 +23,11 @@ pub fn is_whitespace(s: &str) -> bool {
 }
 
 pub fn min_f32(x: f32, y: f32) -> f32 {
-    if x < y { x } else { y }
+    if x < y {
+        x
+    } else {
+        y
+    }
 }
 
 #[allow(dead_code)]