Browse Source

outbound_session: replace TODO with NOTE

draoi 2 years ago
parent
commit
9aea678125
1 changed files with 4 additions and 1 deletions
  1. 4 1
      src/net/session/outbound_session.rs

+ 4 - 1
src/net/session/outbound_session.rs

@@ -621,7 +621,10 @@ impl PeerDiscoveryBase for PeerDiscovery {
                     }
                 }
 
-                // TODO: check every subscribe() call has a corresponding unsubscribe()
+                // NOTE: not every call to subscribe() in net/ has a
+                // corresponding unsubscribe(). To do this we need async
+                // Drop. For now it's sufficient for subscribers to be
+                // de-allocated when the Session completes.
                 store_sub.unsubscribe().await;
             } else {
                 info!(