Browse Source

DEP 0001: remove ext_send_addr, move to accepted & also add task for protocol_addr self addr sending

x 2 years ago
parent
commit
d01f444c23
2 changed files with 3 additions and 4 deletions
  1. 1 4
      doc/src/dep/0001.md
  2. 2 0
      doc/src/dev/contribute.md

+ 1 - 4
doc/src/dep/0001.md

@@ -1,7 +1,7 @@
 # DEP 0001: Version Message Info
 
 ```
-status: draft
+status: accepted
 ```
 
 ## Motivation
@@ -23,13 +23,10 @@ easier.
 | `u16`                | nonce               | Random nonce, randomly generated everytime a version packet is sent. This nonce is used to detect connections to self. |
 | `String`             | connect_recv_addr   | Network address of the node receiving this message (before resolving)                                                  |
 | `String`             | resolv_recv_addr    | Network address of the node receiving this message (after resolving)                                                   |
-| `Vec<String>`        | ext_send_addr       | External address of the node sending this message                                                                      |
 | `Vec<(String, u32)>` | (services, version) | List of features to be enabled for this connection                                                                     |
 
 `resolv_recv_addr` is optional depending on some transports which may not have such an address.
 
-`ext_send_addr` is optional when no external address is set for the node.
-
 The `(services, version)` field can be used to enable certain features in protocols, or even to upgrade protocols to new versions.
 When protocols are first attached, they can add their own data to this field which will be communicated in the subsequent version exchange.
 Any further negotiation needed can be done using protocol specific messages afterwards.

+ 2 - 0
doc/src/dev/contribute.md

@@ -115,6 +115,8 @@ _Tasks are in no particular order. Use common sense._
 23. Separate mining logic from darkfid into a new program and communicate over RPC
 24. Python utility tool (swiss army knife) for working with txs, contract calls and params.
 25. Python event viewer to inspect and debug the event graph.
+26. Fix `protocol_address` for anonymity. There is a loop sending self addr constantly. We should
+    have this mixed with a bunch of random addrs to avoid leaking our own addr.
 99. resource manager for p2p (DoS protection, disconnect bad nodes)