Преглед изворни кода

url: reject empty host after toAscii conversion

Per the change in https://github.com/whatwg/url/pull/497.
Dirkjan Ochtman пре 6 година
родитељ
комит
6b05499d3f
2 измењених фајлова са 3 додато и 20 уклоњено
  1. 3 0
      src/host.rs
  2. 0 20
      tests/setters_tests.json

+ 3 - 0
src/host.rs

@@ -82,6 +82,9 @@ impl Host<String> {
         }
         let domain = percent_decode(input.as_bytes()).decode_utf8_lossy();
         let domain = idna::domain_to_ascii(&domain)?;
+        if domain.is_empty() {
+            return Err(ParseError::EmptyHost);
+        }
         if domain
             .find(|c| {
                 matches!(

+ 0 - 20
tests/setters_tests.json

@@ -950,16 +950,6 @@
                 "port": ""
             }
         },
-        {
-            "href": "file://hi/x",
-            "new_value": "",
-            "expected": {
-                "href": "file:///x",
-                "host": "",
-                "hostname": "",
-                "port": ""
-            }
-        },
         {
             "href": "sc://test@test/",
             "new_value": "",
@@ -1284,16 +1274,6 @@
                 "port": ""
             }
         },
-        {
-            "href": "file://hi/x",
-            "new_value": "",
-            "expected": {
-                "href": "file:///x",
-                "host": "",
-                "hostname": "",
-                "port": ""
-            }
-        },
         {
             "href": "sc://test@test/",
             "new_value": "",